Skip to content

Adding a footer #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 19, 2023
Merged

Adding a footer #31

merged 10 commits into from
Jan 19, 2023

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Jan 17, 2023 •
edited
Loading

fixes #23

Steps:

  • copyright notice
  • logo and links
  • social links with FA icons
    • adding FA to the project
  • refine layout

@fhennig
Copy link
Contributor Author

fhennig commented Jan 17, 2023

I'd like to squeeze this in too: #32

@fhennig fhennig marked this pull request as ready for review January 18, 2023 08:37
@fhennig
Copy link
Contributor Author

fhennig commented Jan 18, 2023

FontAwesome

At this stage of the PR, the CSS and font files are just copied in. This is not ideal.

It would be better if we would add the FontAwesome npm package @fortawesome/fontawesome-free as a dev dependency and then copy the relevant files over into our bundle.

I think the files should be CSS + webfonts, but there is also a JS option. There is more info in the docs: https://fontawesome.com/docs/web/setup/host-yourself/webfonts

The build task that copies all the files into the bundle is in gulp.d/lib/tasks/build.js. My (limited) understanding of Gulp is that it would be best to have a new function to copy the files over which we can somehow merge into there.

@siegfriedweber siegfriedweber self-requested a review January 19, 2023 07:05
siegfriedweber
siegfriedweber approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I have only some optional comments.

@fhennig fhennig merged commit ac8e0b3 into stackable Jan 19, 2023
@fhennig fhennig deleted the feat/23-footer branch January 19, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siegfriedweber siegfriedweber siegfriedweber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a footer to the doc pages (with trademark notes)
2 participants
@fhennig @siegfriedweber